Rube Goldberg Code

[yenknip]

Placeholder for future code that doesn't break existing code? Old code that got removed but not completely?

No harm done by this, the compiler should remove it

[joaopam]

I think it's more likely to be something that was left behind.

There is no harm done by this. That's a rube, though.

Regards

[bsvare]

Sadly, I participated in a code review and the person gave this subvi. I tried convincing him to replace with withat's below the structure, but he said "It works, I'm not changing it"

[PaulG.]

---

@bsvare wrote:

Sadly, I participated in a code review and the person gave this subvi. I tried convincing him to replace with withat's below the structure, but he said "It works, I'm not changing it"

---

Wow. Stunning. This particular developer would probably need 4 weeks to complete a CLD test. 

[GuenterMueller]

aka: Block Diagram Encryption

[JÞB]

---

@bsvare wrote:

Sadly, I participated in a code review and the person gave this subvi. I tried convincing him to replace with withat's below the structure, but he said "It works, I'm not changing it"

---

Code review ettiquite:  That is "Richly Obfuscated Code" if the developer has input to your performance evaluations.

[crossrulz]

---

@JÞB wrote:

---

@bsvare wrote:

Sadly, I participated in a code review and the person gave this subvi. I tried convincing him to replace with withat's below the structure, but he said "It works, I'm not changing it"

---

Code review ettiquite:  That is "Richly Obfuscated Code" if the developer has input to your performance evaluations.

---

I'm lucky enough to have a boss that wants to improve.  I tell him a short way to do something and he likes it.

[altenbach]

---

@bsvare wrote:

I tried convincing him to replace with withat's below the structure, but he said "It works, I'm not changing it"

---

Well, to be fair, your code is not equivalent, because it omits the error handling. 😮

[JÞB]

---

@altenbach wrote:

---

@bsvare wrote:

I tried convincing him to replace with withat's below the structure, but he said "It works, I'm not changing it"

---

Well, to be fair, your code is not equivalent, because it omits the error handling. 😮

---

Nor does it remove all whitespace characters missed that the first time myself

[paulmw]

---

@JÞB wrote:

---

@altenbach wrote:

Well, to be fair, your code is not equivalent, because it omits the error handling. 😮

---

Nor does it remove all whitespace characters missed that the first time myself

---

That will probably become a big bug for someone to discover in the future. "Why can't I insert a 32, it keeps chaning to 0!" (unless that is intended...)