BreakPoint
Why some people say Local Variables are bad...
Wayne.C wrote:Tip (ical) of the iceberg. This app that uses hundreds of local variables and upwards of 100 global variables to boot.
I'm going to play devli's advocate with this one.
Don't like the gloabl read in the first frame so no suprise there, but with that exception there some reasons to see code like that.
THat code looks like a dialog screen where the FP controls are initialized in the first frame. Since locals are more efficient than property >>> value nodes and the diagram is smaller, I'm OK with those.
In the last frame we are gather up the users final settings, so I'm OK with those.
Inside the event struture, I can only comment on what I see. It looks like we could have just used the "rated HP" instead of the local read, yes. But, if this event was created by duplicating another event frame, then the use of locals is valid for a lazy developer (like me). When duplicating an event (or case) with controls, new control will be placed on the FP. If you do the same with an event with locals, you will get duplicates of the locals.
By placing the control in the event structure, a developer can double click on it on the GUI and quickly find in which event that control is used.
Just trying share some other ways of looking at that.
Ben
Ray.R asked:
(was I ranting? ) 
Maybe just a little. 
We can't have you bottling up all that stress now can we?
Unfortunately in this case I can't 'run away'. This is part of a production tester in one of my employers other facilities. I normally stick to stuff for the engineering lab but I seem to be getting sucked into the into the production side as well.
P.S. Kudos for the avatar. Maybe we need to hand out some awards for holiday decorating?
Wayne.C wrote:
Ben wrote:
I'm going to play devli's advocate with this one.
Ben,
I see your point about the efficiency of updating the front panel. I'm usually in RT Target mode and write that code like front panel indicators don't exist. I posted this vi because it is one of the few that will fit on a single screen.
I understand and my comments were not intended to call into question your knowledge. I was just making sure this thread never becomes a citation indicating why some of my delivered code is bad. 
Re-writing that code to reduce the locals to one or none would result in code that is much harder to understand.
But that global on the left and the lack of a type-def going out still makes me question the app as a whole.
Ben
Ben,
No apology needed. Actually, my lack of knowledge is often why I'm on the forums. 
In this case you pointed out a situation where the use of locals can be justified. Time to go back an re-evaluate the programer's use of locals in the rest of the program and see if a pattern emerges.
Here is example of the real headache.
Wayne.C wrote:Ben,
No apology needed. Actually, my lack of knowledge is often why I'm on the forums.
Here is example of the real headache.
Please note that the graders of the CLD and CLA do not read my posts and do NOT share my thoughts.
RE: that image
You don't have to support that code do you? If it works I am suprised and if it does work, that is only until something gets changed.
That code is just plain painful to look at.
Ben
