11-27-2012 11:10 AM
Hi all,
Here i attached my second exam for CLD preperation. Please review the same, feedback critiques are welcome. I completed the same in 4 hour time.
Attached 2012 and backsaved 2010 version.
Waiting for replies.
11-27-2012 09:42 PM
Things i found my self
1.STOP Button : Should not start purge cycle has to quit the application. Not seen really in requirements documentation seen only in user control description.
2.Main Vi Documentation Missing.(Have to concentrate more on documentation)
11-28-2012 08:18 AM
Any replies..
11-28-2012 11:56 AM
Been a while, but a couple things...
The state machine structure looks good and would probably get good marks for style and documentation. You're missing Documentation for the main front panel "VI Documentation" property, which would cost you a point or so.
11-28-2012 10:45 PM
Good Catch Mike,
Yes, Correct myself for these things in future examples. Many thanks for reviewing the same.
Personel: How about my coding level, is this sufficient for CLD or need more?
11-29-2012 10:17 PM
overall nice..
12-04-2012 10:07 AM
Hi,
Here are a few observations. Overall looks functionally good.
1) Logging of pre purge elapsed time, should be 10 sec not 3 sec. I'm guessing you did this to lesson the pain of testing.
2) Pilot proved is being written to the file every time the slider changes on the way to it's value.
Similarly, the boiler running is writing continuously every time the fuel knob changes on the way to it's value.
It seems the logging is occurring as I am moving the knob or slider, when I click the value it only logs the final value. Looking at the code this is a result of the event case using the "change value" event. It would be better to read the changed value on a mouse up event, in general, but this is acceptable.
3) Forced draft fan turns off when the fuel control valve is activated (Start and run step 2) See also shutdown and purge instructions.
4) Application turns off during the shutdown. This is not in the requirements. The end result of a shutdown should be lockout state with the VI running.
5) When pressing the stop button the application goes through a purge step with timing and LED operation. Although the stop button functionally is not specifically listed in this specific requirements, adding this level of functionality would not be a good use of time during the exam. Probably best to just stop the application.
Be sure to practice with a timed trial.
12-04-2012 11:10 PM
Dear Mark,
Thanks for your review. The points you mentioned is true. I will take care all those things in the remaining examples.
Thanks again