Really need help in this machine

[SJPAN]

I wrote a machine but I could not fix many bugs. Especially, when I start the machine, all the control in cluster will be disabled( I did not set it ). Moreover, when I run it, it will somehow happened like return to initial after the first selection(didn't set it). Here is my machine.

[Bob_Schor]

I can unzip your attachment, but all I see in there are two VIs written in LabVIEW 2024 (which I cannot open, as my most recent version is 2021), 4 controls (also unopenable), and a folder with "log.txt" that seems to show error conditions.

• Why aren't you developing in the context of a LabVIEW Project?  Have you not learned about LabVIEW Projects and the LabVIEW Project File, such as "Car Wash.lvproj"?  When you start LabVIEW and want to start a New Project, just push the "Create Project" button on the opening "Getting Started" window.  (See Below)
•  This is what my opening Screen looks like (in LabVIEW 2021).  I've got two "recent Projects" I can click and open, and if I want to start a new Project, I would click "Create Project" and follow the prompts.  Note that you don't need to name your Project "Project <something>" -- I've adopted the style of naming my Project file starting with "PROJECT" ... 
• To allow "very experienced LabVIEW Developers" (who, unlike new students, are much less likely to have the "latest version" that can open your code), do a "Save for Previous Version".  I recommend specifying LabVIEW 2019 or 2021 as useful choices.

Bob Schor

[SJPAN]

Thank you for your reply! I'm very new to Labview. I will recreate a project to make it.

[Xonmyth]

Hi SJPAN,

You will have to do several improvements here. First your block diagram scared me. It does not have to be this big: (had to zoom out quite a bit)

EDIT:

Missing Data Flow Understanding:

Additionally:

1) You have nested while loops.

2) Overly used local variables.

3) Missing ENUM (fixed).

4) Too many flat sequence structures.

Typically, you would want to use one main while loop and then a case structure in it to control the states. Step by step processes.

I personally think that you should re-start referencing car wash project posted here: https://forums.ni.com/t5/LabVIEW/CLD-Solution-Car-Wash-System/td-p/986134  https://forums.ni.com/t5/Example-Code/CLD-Car-wash-solution/ta-p/3491853 and understand what you did wrong, how you can improve your code.

I have converted your project for previous version (2019) if someone else wants to take a look.

[altenbach]

After a 10 second look and an auto-cleanup, I will stay away. The only nice thing is the front panel (and that was probably provided). (remember, don't judge a VI by its front panel!)

• All you need is a simple state machine that fits on one or two postcards
• Learn about dataflow
• Connect your control and indicator terminals, they are just UI elements. The wire is the variable!
• Eliminate ALL local variables. They even blur the distinction between control and indicator in your case.
• No, you don't need any sequence structures.
• etc.

I have moved your thread to the "certification forum" where many car wash examples are already posted and commented. Look for them!