I have a script that ran in DIAdem 2010 but will not run in 2018. The script has "Option Explicit" and faults on the line that contains the command Call Data.Root.Clear() with the error undefined variable. What has changed in 2018?

Hi lhandph1, I took the liberty of rewriting the script. If all you're doing is taking the average of each channel you load, I recommend the simple CCh() function instead of the full StatBlockCalc() command. This makes it easy to write each average value individually without needing to copy result channels. I also simplified the folder selection code, though you could further simplify it with a DirListGet() command instead of manually looping over all the files in that folder yourself. Finally, I used channel object variables instead of the brittle channel numbers. This code runs in DIAdem 2018. OPTION EXPLICIT Dim a, aMax, StartFolderName, StartFolderPath, fname, fpath, Groups, FileChannel Dim j, jMax, AveGroup, DatGroup, AveChannels, DatChannels, AveVal, MaxGroupCount, CurGroupCount Call Data.Root.Clear() Call GetTdmsFiles(StartFolderName, StartFolderPath, fname, fpath) Data.Root.Name = StartFolderName Set Groups = Data.Root.ChannelGroups aMax = UBound(fname) FOR a = 1 TO aMax Call DataFileLoad(fpath(a), "TDMS", "Load") IF a = 1 THEN MaxGroupCount = Groups.Count Set AveGroup = Groups(MaxGroupCount) Set AveChannels = AveGroup.Channels jMax = AveChannels.Count Set FileChannel = AveGroup.Channels.Add("FileName", DataTypeString) FileChannel.Values(1) = "Channel #" END IF CurGroupCount = Groups.Count Set DatGroup = Groups(CurGroupCount) Set DatChannels = DatGroup.Channels FileChannel.Values(a+1) = fname(a) FOR j = 1 TO jMax AveVal = CCh(DatChannels(j), 0) ChnLength(AveChannels(j)) = a+1 IF a = 1 THEN AveChannels(j).Values(1) = j AveChannels(j).Values(a+1) = AveVal NEXT ' j FOR j = CurGroupCount TO MaxGroupCount+1 Step -1 Call Groups.Remove(j) NEXT ' j NEXT ' a Call Data.Move(FileChannel, AveGroup.Channels, 1) Call WndShow("VIEW") Sub GetTdmsFiles(StartFolderName, StartFolderPath, fname, fpath) Dim p, y, WSH, FLD, objFSO, objFolder, objFile Set objFSO = CreateObject("Scripting.FileSystemObject") Set WSH = CreateObject("Shell.Application") Set FLD = WSH.BrowseForFolder(0, "Select a folder", &H40 + &H1) StartFolderName = FLD.Items.Item.Name StartFolderPath = FLD.Items.Item.Path Set objFolder = objFSO.GetFolder(StartFolderPath) p = objFolder.Files.Count ReDim fpath(p) ReDim fname(p) For Each objFile in objFolder.Files If UCase(objFSO.GetExtensionName(objFile.name)) = "TDMS" Then y=y+1 fname(y) = objFile.Name fpath(y) = objFile.Path End If Next ReDim Preserve fname(y) ReDim Preserve fpath(y) End Sub ' GetTdmsFiles() As a postscript, I really don't see the point of using the first row of each channel to store the "Channel #". You've got the channel name in the VIEW table heading, and we could easily add a channel property to show the "Channel #" in the heading. Placing this index in row 1 of each channel just makes it hard to run further calculations, such as the maximum and minimum (average) value for each channel across all the files analyzed. Still, I left the output the way it was, since I figure chances were you had other scripts or REPORT layouts that were expecting it that way. Brad Turpin DIAdem Product Support Engineer National Instruments

DIAdem

Diadem 2018 undefined variable

Solved!

Author

Wow Brad,

Great job. Thanks for the help!

Message 11 of 11

(279 Views)

DIAdem

Diadem 2018 undefined variable

Re: Diadem 2018 undefined variable