A Thing of Nightmares. Recommendations when reworking abhorrent code?

[Ben]

That VI has TOO much documentation. Makes me think it may have been a product of NI at one time.

Try taking a look out how it is used in context of the calling code then do a Find Examples >>> Search "Phase Locked Loop".

You may be able to find functions that are doing the same thing and possibly throw that VI away completely.

I do not recall the robust set of "point by Point" VIs being around in 2004. My point is a valid replacement of that VI may already exist.

Ben

Ben

[etvg]

LockInPLL.vi does reside in a folder titled "MultiChannel LockIn - both DAQmx & Simulated Data NonCensored". You may be on to something. 

[AnalogKid2DigitalMan]

One of the comments in the code mentions Aljosa Vrancic who had ties to NI at some point:

https://www.google.com/search?safe=active&biw=1920&bih=953&ei=F5poW8WLGKrc0gKBkLYw&q=Aljosa+Vrancic+...

-AK2DM

[etvg]

What baffles me is how disorganized it is. I understand every code has elementary stages but I would be surprised if NI published something like this for public use. Looking at those modification dates, despite being a now 16 year old code, it would less surprising if this is a modified version of an originally NI code. So many questions, so few answers. 

[Ben]

---

@etvg wrote:

What baffles me is how disorganized it is. I understand every code has elementary stages but I would be surprised if NI published something like this for public use. Looking at those modification dates, despite being a now 16 year old code, it would less surprising if this is a modified version of an originally NI code. So many questions, so few answers. 

---

NI had relatively few LV developers back then. They were heavy in C etc. I remember talking to Paul Austin (holds the patent on the LV Picture control) and him talking about being excited to be able to start programming in LV>

There was also a time when NI hired a bunch of PHDS in math and put them to work implementing higher math functions in LV.

Not saying that all of that mess was from NI but the beginning may have been.

Ben

[AnalogKid2DigitalMan]

Looks like a version of it made it to press many years ago, see Travis' link in the 2nd post.

That vi appears to be in the llb, the icon and documentation match, however the LockInPLL is protected.

http://natinst.public.daq.dsa.general.narkive.com/xXrKTBvF/lock-in-amplifier-and-daqmx

-AK2DM

[etvg]

Yeah, I suppose you're right, maybe this was put together at a time where this subVI was in early stages from NI and long since forgotten and/or removed from being supported. 

[AnalogKid2DigitalMan]

The revision in the protected one I found is 1314 from LabVIEW 7.1.1, the one you posted is at rev 1325, not sure if anyone before or yourself incremented the revision.

-AK2DM

[Ben]

Could you post the llb you found that VI in please?

Since yours said "unsensored" and the one AnalogKid2DigitalMan found says "sensored"...

Ben

[etvg]

Yeah I guess it is a relic of times past. That makes me wonder if NI or someone else has an updated subVI published with similar functionality..