LabVIEW
Case Selector and Conditional Programming
Nobody here will have the patience to look at a disorganized diagram that is the size of many (many!) screens. Can you explain where the case structure is that you mentioned?
Please re-architect as a simple state machine that fits on a typical screen.
Constantly creating and destroying virtual channels in both cases of a case structure with code that only differ in a single boolean is just plain silly!
@altenbach wrote:
Constantly creating and destroying virtual channels in both cases of a case structure with code that only differ in a single boolean is just plain silly!
Just to clarify what I said...
(Sorry, I don't have drivers installed, so these VIs are missing for me)
Overall, there is so much code smell that I really think you should do a few basic tutorial. You are not ready to dove into the deep end. Most of what you are doing could be done better and with 20% of the code.
For example, also compare your code with an equivalent alternative.
So let's analyze you V3 and V4 solenoid controls.
You have two inputs ("PG3 reading" and "Target pressure", where the target pressure is read only once, and never again).
You have two boolean outputs, V3 and V4.
Following the extremely long crisscrossing branched wires and cleaning things up a bit, I made a small test VI where you can see how the booleans currently depend on the two inputs. Once validated, the comparison code should be made into a subVI with two DBL inputs and two boolean outputs. It is very well possible that the logic needs to change, it simply does not look right...
Can you explain in words how the solenoids should behave (e.g. if PG3 within ~2% of the target, then ABC, etc. How often can a reading be negative or zero, etc.)
Please add a few words when posting pictures and maybe quote relevant sections you are replying to.
As I said, you need to clean up your code. It is way too convoluted and not debug-able. Have you checked the logic in a small test program similar to what I showed earlier?
