LabVIEW
Error Memory Full
@Credible wrote:
Im not sure, how to upload the vi in one file with all its sub vis, so you guys could take a look at the programm.
Zip up the project and post the zip file. This works as long as the resulting file is not too large.
As far as your memory issue, the most common causes for this would be 1) building arrays or strings inside of a loop and 2) not properly closing references. If you can just isolate the VI that is throwing the error, that would help us help you debug the application.
@Credible wrote:
... but is there any method to save alle the referred sub vis as well?
You can do a "save for previous" on the toplevel and pick the same version. It will create hierachy of all dependencies that you can zip up.
I don't see anything that would give you glaring memory errors, but the code is very disorganized, so it is hard to tell. Of course there are glaring race conditions due to the blatant overuse of local variables and it seems you don't understand them. For example in the following segment you write the same value to the terminal AND to a local variable of the same terminal (100% redundant) and then read the value from another local variable. You cannot guarantee that the read happens only after the write, but the result will depend on the order.
For each of the three sections, you can delete both locals and just wire across. Thinks dataflow! The wire is the variable! (This is only the top if the iceberg!)
Not sure why you need all these blue "-1" constants (six in this part alone!!!) if we have the negate function. Also note that both cases contain the same code, so why do these case structures even exist???
You have tons of subVIs that seem mostly identical, maybe only differing is a small part. Make the small part a control and make the subVI reentrant!
Why is the front panel and diagram maximized to the screen? Why do you have such a gigantic connector pane of nothing is even connected to anything?
Hi Credible,
@Credible wrote:
So there is this main vi (I guess) that i open, but is there any method to save alle the referred sub vis as well? I can't find it
You were asked to ZIP the wole project, but instead you choose to attach only a single VI…
Do you need any more help for ZIPping a project folder?
@Credible wrote:
But still, here is the vi that makes problems (and i cant tell which sub vi is the exact problem,
On your VI:
It's no wonder your VI "makes problems" when there are those silly race conditions and non-sense code!
Edit: While I was writing my message Christian stumbled over the exact same problems in your VI…
Hi Credible,
@Credible wrote:
I would be thrilled to get some valuable input on how to improve things. I am more than happy to learn this code, so teach me the proper way.
There is no project file in your ZIP (atleast I didn't see it)!
Start with creating a proper lvproj file for your LabVIEW project!
These are two of your subVIs:
They are IDENTICAL!
Instead of creating several copies of the same code you should just use the very same VI!
Please check all your subVIs for identical code and remove copies…
(Are you sure you don't need to close all those DotNet references in your subVI?)
As said, there are many things to improve about the code, but if your boss is happy with its functionality, don't waste time refactoring the code. Focus on the problem given to you and try to fix just the error.
Some questions: Which subvi, and more specifically, which function inside that subVI, is giving the error? What is the actual error code and description?
If you are having trouble. Select View>>Show Tools palette and select this option. Then click on a wire that is giving the error to get a detailed error description.
Alternatively, add after your function that gives the error.
