LabVIEW
Error messages
@johntrich1971 wrote:
@labview99 wrote:
Thank you.
Sorry, what do you mean when you say to try to clean that to fit on one screen? I don´t understand what do you mean..
Your block diagram is extraordinarily large. It can actually be made better with Clean up diagram from the Edit menu (if you write good code this actually makes it worse, but it might be a good starting point for you). You've got lots of white space. Put things closer together and make the wires neat. Making the block diagram so large means that many have to scroll to see the whole program, making it extremely difficult to follow the flow. Read up on LabVIEW style for more information.
^^
A useful thing you might not have known.
Holding Ctrl and dragging the mouse adds whitespace between things.
Holding Ctrl + Alt and dragging the mouse removes whitespace.
Works on the front panel and block diagram.
Can do strange things when removing space in Case Structures (or things with hidden code) but generally still useful if used with a bit of care (or in small chunks at a time).
That's basically the main tool I used to produce this edited version.
If you need to pass data from one state to another then yes you do that with a shift register. Don't forget to wire the value across for those state where the value does not change. If you start getting too many shift registers one common method is to make a bundle that contains all of the data that needs to be passed and then use bundle by name and unbundle by name to update the values.
@labview99 wrote:
Thank you very much for all your advice and for your help!!
Do you think that now is it doing ok what I want it to do?
I attach the program
That looks a lot better. There's still some room for improvement. Try to make your wires straight when possible. Also, when possible try not to have wires which go from right to left. Finally, I saw at least one hidden wire.
You still have a lot of controls/indicators that I don't think that you need. Replace those with the values that you would have sent to the subvi.
The coherence dot on the enum is a bit concerning
You should consider changing the enum into a type-def
@Frozen wrote:
The coherence dot on the enum is a bit concerning
You should consider changing the enum into a type-def
Good catch Frozen. Yes, enums should be a type def.
@Frozen wrote:
The coherence dot on the enum is a bit concerning
You should consider changing the enum into a type-def
To expand on this thought a bit:
The reason why you want to do this is because changing the items in the typdef'd control will flow its changes to all instances of that typedef. The change will flow to your state case structure and it will break your code because there won't be a match in the case statement for the new item. This makes it very easy to figure out where you need to add the additional code for your state machine.
Another advantage is that if you change the name of an item, any case structures depending on that enum get updated so the code WON'T break unnecessarily.
Deleting an item will also cause broken code. You can then easily find the case structures that are broken and delete the orphaned case.
I should probably not jump into this....
There are still too many coding issues for you program to work.
Most notably, you are not using the shift register correctly.
You need to maintain the information between cases by wiring every case all the way across, like this for *every* case of your state machine.
