LabVIEW
Help Making Program Run Faster
This code is beyond repair, maybe you want to start from scratch.
- Many of CPU burning loops that suck all power out of the CPU, some with literally tons of property nodes that write the same property over and over again, millions of times per second. A property only needs to be written when the value changes!
- All UI loops need a wait.
- Emergency stop will not work due to dataflow problems.
- Almost endless sequences, many in duplicates.
- Full of FOR loops with N=1. They can all be deleted without change in result.
- All these small while loops in the sequences make no sense at all.
- Duplicate indicator names (image: why are there two indicators with the same name: "Station ID"? This is very dangerous because you use a local variable. There is no way to tell the parent of the local by looking at the code if they have the same name!)
- Race conditions! (Image: Why do you write to a terminal and then read from a local?? Most likely, the local gets read before the terminal is written, thus you have a race condition and potentially unpredictable results. Delete the local and just branch from the wire going to the terminal).
- Your diagram is way too big (~30 monitor screens!!). With proper coding habits (state machine!), all this code should fit easily on one screen. try it!
- ...
- ...
- ...
Well, after Altenbach's description... I guess I'm glad I'm in the middle of a LabVIEW install and couldn't look at the code. 🙂
What LV version is the software in? I might just have a looki, I need a booster this morning......
Shane.
