08-08-2006 11:07 AM
08-08-2006 11:29 AM
08-08-2006 11:46 AM
08-08-2006 01:07 PM
08-08-2006 01:09 PM
08-08-2006 01:29 PM
08-08-2006 01:30 PM
08-08-2006 01:49 PM
Just a few quick comments: In your consumer loop, you have the error cluster going to the stop on the while loop. This may or may not leave your equipment in the last state, and not shut down "orderly". That may cause a dangerous situation depending on where it is in the test. Also, if there is an error, you will have to close the program to be able to run the test again, as it will stop the consumer loop and it will not take any more inputs from the producer loop.
You may want to initialize the Final Acq Array by wiring an array constant to the shift register, as well as the other shift registers in the comsumer loop.
In your Aquire, ramp, etc states, you may want to make a subvi that does some decision making. It will test the values aquired and the ramp data to see if it is out of the limits. If it is, it can then jump out and go to s stop or abort state and safely shut down the equipment.
Your producer loop has a wait ms of 900, so that means that even if you hit the stop button, it can take almost a second for it to register. I am not sure how critical it is that you stop quickly or not.
I will keep looking at it through out the day, and try to make some more comments.
also, your global vi is missing you may want to post that as well, just to make it complete.
Kenny
08-08-2006 02:23 PM
Sounds like quite a project for a 'newb'. Your software background will serve you well. Moving from text to icon programming takes some getting used to. No offense to the TestStand sales pitch, but you really don't need it. Don't be intimidated, but like most large appliations this is perfect for a state machine. Each piece of equipment you have can be run under it's own subvi, and even most of them can be run with a state machine if they have more than a few modes of operation. Learn how to open, run and close these with references as needed. Use shift registers and functional globals to store/retrieve data these subvi's generate. And stay away from global variables ...
PaulG
7.1 moving to 8 very soon ...
08-08-2006 03:39 PM