LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

Multy Slave read Modbus rtu

Hello!

Please look at this Vi. it is multy slave read. it is work, i have value from heat pump and solar inverter. it is a part of code/register read and write. Any tips for optimization of this Vi?

Thanks!

0 Kudos
Message 1 of 2
(375 Views)

Hi black,

 


@black1 wrote:

Any tips for optimization of this Vi?


  • Get rid of the flat sequence, use wires to enforce dataflow execution!
  • Don't split the Modbus reference, use just one reference wire!
  • No need to close the same reference twice…
  • Cleanup the frontpanel and arrange all those scattered indicators more nicely.
  • Do you really need 6 indicators just to display a timestamp?
  • Cleanup the block diagram to follow the StyleGuide. Straighten wires, subVIs, …
  • Use proper datatypes to avoid unneccessary coercion dots. (Example: HeatPump_temp)
  • Do you really need 10 additional indicators just to build on SerialNumber from 5 U16 registers?
  • Why do you need to duplicate code 5 times for the conversion of U16 to two chars? Use a loop instead of all that duplicated code!
    Example:
Best regards,
GerdW


using LV2016/2019/2021 on Win10/11+cRIO, TestStand2016/2019
0 Kudos
Message 2 of 2
(130 Views)