LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

My stoplight.vi for CLD practice exam

I am preparing for CLD and looking for comments on my implementation of the "stoplight" CLD example question.  Any comment would be appreciated.  Kudos will be distributed liberally.

 

The pdf for the example question is in this zip file:

ftp://ftp.ni.com/pub/devzone/epd/2419.zip

Download All
0 Kudos
Message 1 of 5
(3,379 Views)
j_osh_o-

Due to my affiliation with National Instruments, unfortunately I cannot comment on your code.  If anyone else has any comments, please feel free to comment.
Regards,

Mike S
NI AE
0 Kudos
Message 2 of 5
(3,326 Views)

It looks like your code does everything that the clad exam wants. I see that you documented everything but the main vi. You might just want to explain what the purpose of the mian vi is. I think you code is simple and east to read. The state machine is simple and works good and everything seems to flow nicely. You document well what is going on in each loop.

 

I hope this was userful info.

Tim
GHSP
Message 3 of 5
(3,313 Views)

Thanks aeastet.  One thing I thought about after I finished was that I hadn't documented the meaning of each state in the state machine, I think this is what you are talking about.  The names in my enum are sort of self documenting, but probably not enough.  I never worried about making nice straight lines before but I am getting faster 🙂

0 Kudos
Message 4 of 5
(3,304 Views)
Keeping everthing orginized, so it fits on one window, flows from one side to the other, wires that are easy to see no over lapping unless there is no way around it, use few local variables, flat sequence vs stacked, document everything on the CLAD they can not take points off for too much info. Good luck with your exam.
Tim
GHSP
Message 5 of 5
(3,300 Views)