LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

NEEEED HELP!! IM NEW!!!

Can we see your code now that you have modified it?

 

Mike...


Certified Professional Instructor
Certified LabVIEW Architect
LabVIEW Champion

"... after all, He's not a tame lion..."

For help with grief and grieving.
0 Kudos
Message 11 of 14
(544 Views)

I haven't looked at the code, but I want to give kudos to the OP just for asking the question. This is exactly how I learned LabVIEW; do stuff, ask questions about ways to do it better, then take those suggestions and refactor. Slowly the knowledge will build, especially when you leave your ego out of the way and are willing to learn and take criticism. Spot on with the approach and good luck on your project. I encourage you to listen to Mike's suggestion and post the modified code to get further feedback.

Message 12 of 14
(540 Views)

@Yanzly wrote:

Im tasked to create a software for a integrated security alarm system


Lert's first look at your code and point out some problems.

 

  • I assume that the picture path never changes, so why do you need to read and convert the picture file with every frame of the stacked sequence? Once is enough!
  • There is no need for all that complicated boolen math, just iterate over the buttons. Make it a button array to significantly simplify the coding.
  • Not sure why you read the mouse coordinates.
  • Don't use orange terminals for integers.
  • You can eliminate all local variables. They are not needed.
  • Same for the sequence structure.
  • repetitive operations belong inside a loop. Only one code instance needed.
  • dont wire inputs if the defaults are what you want (start angle, arc size)
  • ...

Here is a quick draft attempt to show some ideas. Modify as needed. I don't have your picture, so I left it blank. Just flip the diagram disable structure to use a background image instead.

0 Kudos
Message 13 of 14
(514 Views)

@GregFreeman wrote:

I haven't looked at the code, but I want to give kudos to the OP just for asking the question.


Goes to show that whoever screams the loudest with their subject line in this forum gets the attention.

 

 

0 Kudos
Message 14 of 14
(503 Views)