NI Traffic Light CLD Soln vs mine

[smercurio_fc]

Your "explanation" of error handling didn't explain anything. You are calling property nodes and they have an error out. These should be wired so you can handle an error with them. Is an error likely? Probably not. However, it's possible. Also, who said anything about duplicate error clusters?

You seem to be misunderstanding the distinction between necessary wire bends and superfluous wire bends (AKA sloppy wiring). Your VI has numerous superfluous wire bends.

You also seem to be missing the whole point. You're focusing on "nickel and diming". That's not the point of the exam. The point of the exam is to instill proper design and coding practices. The points are to indicate where a program is lacking this. Your attitude makes it clear that you don't seem to care too much about this and are more worried about what's considered to be "points off". To be honest, I doubt you will ever pass this exam with that attitude.

[TCPlomp]

Your subVI should do a sanity check on it's inputs, thus an error out seems appropriate.

The enum given is only given in the example. There is never stated you should use it, and if you choose to use it, then use it and don't connect it to your own enum.
The power of the queue is that you can overrule the FIFO functionality of it, this might be usefull (even in a CLD exam).

In your example (12.png) you had two shift register containing a timestamp. It was not clear to me what the meaning of those two were, thus you need documentation.
My rule of thumb:
Documentation is at least 50% of any programming time.
(and no I don't stick to that)

Ton

[richjoh]

Ahhh, Altenbach

excellent observation, the pic post really help. As at this point my eyes are  quite bored with code. I could have move the duplicate const outside early on... but again this is really nit picky I would think during an exam.

Would you take points off for this if you were judging subjectivly let say??? Of course you would if an established point system had directly noted this ahead of time.... Anyhow I thought the point is to add up points not deduct what you see fit.

[JeffOverton]

Why wouldn't he deduct points for taking up unnecessary memory space by instantiating six copies of one constant?  If you did a similar thing inside a side loop, you would be constantly creating and destroying constants, taking up memory and cpu cycles.

[richjoh]

Your "explanation" of error handling didn't explain anything. You are calling property nodes and they have an error out. These should be wired so you can handle an error with them.

smercurio,

you made your point, but if property nodes error handler must be wired, I suggest NI make them "must be wired for run"... otherwise... they can be avoided. it (the way it is) currently does the job.

[Ben]

Sorry about not following long with this thread but I'll try to catch-up.

1) Unless you are concerned about the 8 picoseconds it take to support the un-used connector pane terminal, always choose a pattern that has extras.

2) I am not responcible for the traffic lights in PA so no harm to me. What is really crazy are the traffic circle of New England. The rules there seem to be A) Don't make eye-contact, that implies you are yielding B) If having a hard time getting in, look for a car that cost more than yours and aim for it, they'll slow down. C) The only thing more dangerous than driving in NE is driving in Steeler country with ravens plates.

3) Has anyone looked at the VI's the DAQmx wizards produce? Since when is it leagal to wire an input to the right side?

4) I would never attempt to write an XControl for an exam. They are applications in themselves and the last thing I want to have to write two apps in a time limit.

Ben

[richjoh]

JeffOvert,

Your correct,

but, I'm not using a 286PC running DOS worrying about cpu time and cpu cycles for this one. I have plenty of power under my hood here. My task manager cpu processing is nill... Maybe some much much bigger project, not this one...

Because I copied the State going from one to the next the code const were copied... ah I'm going to lunch now...

[richjoh]

JeffOvert,

Your correct,

but, I'm not using a 286PC running DOS worrying about cpu time and cpu cycles for this one. I have plenty of power under my hood here. My task manager cpu processing is nill... Maybe some much much bigger project, not this one...

Because I copied the State going from one to the next the code const were copied... ah I'm going to lunch now...

[EdDickens]

richjoh wrote:

 it (the way it is) currently does the job.

You're still missing the main objective of the exam. They are looking for proper application architecture, and error handling is part of that.

Now weather Property Nodes need to be error handled is a question. Sometimes I do, sometimes I don't. It depends on what they doing.

richjoh wrote:

Anyhow I thought the point is to add up points not deduct what you see fit.

---

If I were grading an exam like this, I would start out assuming they have the maximum points possible, then deduct points as I finds errors.

[richjoh]

Ed, I already explained my issue i.e. slapping an error handler on the block diagram above. OK, I'll say it again. During the exam thats all that needed, an error in, error out and Simple Error handler pop-up VI from the tools pallette. I guess if I wired all my errors nodes I will get less extra off too.

In all 16+ years at school, they use a method tallying up points for credit. In my opinion, for exams like this, a rock solid point system should be used to tally the grade.

"" If I were grading an exam like this, I would start out assuming they have the maximum points possible, then deduct points as I finds errors.""

find errors??? you mean find code thats not up to your guidance standard or code that errors??? Let say the code does the job. If code is not up to your stardard then yes, some would fail. If you mean Code that does not error, well that would pass.

Anyhow the exam is 4 hours, I could sit here an enhance enhance all day with the code if I like. Most candidates will be cut for time on dressing up there code.