Security system CLD exam review

[leoatul]

This is similar to solution online
Please let me know if you have any general comments on the solution or any other comments to my questions below

1. I have created a project. Was it necessary or does it matter.
2. I put data in a Data folder. Does I need to create a separate folder?
3. It asked for test file. I used a .csv file instead of .txt. Is it ok to do that?
4. I used only one case for alarm, bypass and tamper switch instead of using 3 cases for solution online.

Code is in LabVIEW 8.6

Thanks

[leoatul]

I meant test text file above.

[Mark_Yedinak]

Overall this is a pretty elegent solution. There are a few things that you will want to improve though.

1. This one jumped out at me immediately. Be very aware of extra and unnecessary bends in your wires. Try to line things up better and avoid all the extra bends.

2. I would use better names for your subVIs. Use names that are descriptive yet meaningful. Logic.vi is not very meaningful or descriptive.

3. I would not modify or change the requirements of the test. If they specify a text file then use a text file. Part of the exam is to determine if you can follow requirements. Changing them is not receommended.

4. Avoid objects overlapping each other. For example look at the labels in your Initialize state.

5. Avoid using "Use default if unwired" for your tunnels on structures.

6. Make sure to add descriptions for all of your controls and indicators including the ones in your subVIs.