Traffic Light CLD Critique please

[GregFreeman]

Have at it. Go ahead be harsh. There may be some extra junk in the project I didn't clean up like some subVIs I ended up not using or elements in my cluster I didn't use, so feel free to ignore those

[GregFreeman]

woops, forgot a wait in the bottom loop...

[RTSLVU]

The left turn "sensors" do not always work.

[CharlieM]

Howdy! The functionality and architecture are rock solid (minus the missing wait, you railed one of my CPU's cores). However, I may have missed some small thing since I didn't take the time to read the test. 

1. Make sure you hit all the little documentation thingies like tip strips. Silly, but points. I'm sure you will add this when you actually take the CLD. 

2. Move the Release Queue such that it is forced to execute after the consumer loop shuts down (maybe after the merge error or use a flat sequence some how). This will keep you from having to create a subVI to handle an avoidable error.  

If you can put something like that together in less then 4 hours you'll be golden!  

[GregFreeman]

---

RTSLVU wrote:

The left turn "sensors" do not always work.

---

They do work. When they are pressed it queues up the left turn sequence. I have the button set to latch so that it returns to its false state once read by the event structure. They aren't supposed to immediately go. Once the left turn sequence begins, then they will change.

Now, that said, there is a bit of discrepancy. The example solution I looked at has the arrows go immediately if it's that point in the sequence. I, however, interpreted it to mean finish up the entire sequence it's in, then the next one include those left turns. I guess it's a matter of interpretation. I don't think that would have made or broken me on the exam. I'm more concerned about the architecture.

[TCPlomp]

Yes you definitly missed some documentation points (maincluster.vi), the traffic lights on the FP (look at the context help), your typedefs.

Second your timer.vi and lightcluster indicators have no customized icons.

Third, you let the user close the window, but you don't handle the close event, that's bad.

Ton

Message Edited by TCPlomp on 22-05-2010 02:19 PM

[GregFreeman]

Yes you definitly missed some documentation points (maincluster.vi), the traffic lights on the FP (look at the context help), your typedefs.

I'll be sure to do those as I go next time so I don't miss them 

Second your timer.vi and lightcluster indicators have no customized icons.

Do  I need to customize the timer VI icon? It is just their express timer VI.

Third, you let the user close the window, but you don't handle the close event, that's bad.

Didn't even think of this! Thanks for pointing that out.

[TCPlomp]

---

for(imstuck) wrote:

 

Second your timer.vi and lightcluster indicators have no customized icons.

Do  I need to customize the timer VI icon? It is just their express timer VI.

---

Well I was looking at all the VIs in the project. If you don't use the VIs you should remove them from the project. (in fact it were empty VIs).

Ton

[RTSLVU]

---

for(imstuck) wrote:

---

RTSLVU wrote:

The left turn "sensors" do not always work.

---

They do work. When they are pressed it queues up the left turn sequence. I have the button set to latch so that it returns to its false state once read by the event structure. They aren't supposed to immediately go. Once the left turn sequence begins, then they will change.

Now, that said, there is a bit of discrepancy. The example solution I looked at has the arrows go immediately if it's that point in the sequence. I, however, interpreted it to mean finish up the entire sequence it's in, then the next one include those left turns. I guess it's a matter of interpretation. I don't think that would have made or broken me on the exam. I'm more concerned about the architecture.

---

Maybe I am doing something wrong, watch the attached video...

It won't let me attach a video, I will find someplace to upload it and link to it.

Message Edited by RTSLVU on 05-24-2010 07:40 AM

[RTSLVU]

http://home.comcast.net/~rtsears/MainVideo.AVI

That took forever, anyway you might want to just download the movie file as I don't know how well it wil stream...