10-29-2008 04:59 PM - edited 10-29-2008 05:01 PM
I completely agree with Dennis. Its very hard to help when reading your code takes so much effort. However, I couldn't help but take this opportunity to display what the new "Cleanup Block Diagram" feature in LabVIEW 8.6 will do with a badly organized block diagram like this. I've attached the results I got by simply opening the posted VI, and running the default configuration on the Block Diagram Cleanup feature, and then saving it. The first attached file is for 8.6, and the second one is 8.5.
Note that this gives you a good starting point, but it is in no way a replacement for good coding practice in the first place. Moreover, the cleanup feature does NOT effect the actual operation of you code at all (meaning all the problems with your implementation that Dennis mentioned are still there,) it just reorganizes the diagram to make it easier to read, and perhaps find these problems easier.
Also, as a fair warning, this new feature can play havoc with free labels, so be careful and have your hand ready on the undo button if you don't like what you see (you can also configure the way the cleanup feature works from the LabVIEW options located in the tools menu.) A neat way around this problem is to group free labels with block diagram objects. Then the placement relative to the grouped objects will not change.
I know this is a bit off topic, but the block diagram posted cleaned up well, and I thought it was worth sharing.
11-02-2008 11:36 PM
11-02-2008 11:41 PM
Thanks Captain Kirby,
I am learning a lot from you people , once again thanks.