Darnell:
To reply to your post on 08-19-2009 12:16 PM:
In the code you posted, you never call BIT_CONVERSION(), so it's never executed.
Here's a troubleshooting tip: if you think a chunk of code isn't working, put a breakpoint in it and view the variables and execution as you step through it. If you had put a breakpoint in BIT_CONVERSION(), the breakpoint would never have been reached, which should indicate to you that the code was never executed.
CVI Help has a good sections on Breakpoints. Take a look at it.
Here's a couple of tips on your UIR.
Give meaningful names to your controls. For example, instead of calling the input for Switch 1 NUMERIC_2 and the output BINARY_READ_6, call them SWITCH1_INPUT and SWITCH1_OUTPUT.
Use the input control properties to set input limits. If the maximum number to be entered is 8, edit the control and set the Maximum to 8. That way you won't get a runtime error if the operator enters a higher than expected number.
Why do you use String control to label the switches instead of using the controls' built in labels?
Why do you want to set all your switches at once? If you only change one input value at a time, you only need to update one output at a time. But that doesn't mean you need 5 functions to do the conversion and display. The easiest thing to do will be to have 5 callback functions that all call the same conversion function, passing the input control ID and the output control ID.
// Here's the new prototype for BIT_CONVERSION()
int BIT_CONVERSION(int inputControl, int outputControl);
// here's one sample callback
int CVICALLBACK DECIMAL_INPUT_1 (int panel, int control, int event,
void *callbackData, int eventData1, int eventData2)
{
switch (event)
{
case EVENT_COMMIT:
// the name of the input control parameter ('control') will be the same for every callback,
// since it's automatically passed to the callback,
// but the output control parameter (PANEL_BINARY_READ_6)
// will be unique for each callback based on which control to write to
BIT_CONVERSION(control, PANEL_BINARY_READ_6);
break;
}
return 0;
}
// here's the updated BIT_CONVERSION() function
int BIT_CONVERSION(int inputControl, int outputControl)
{
char myString[9]; // 8 characters followed by NULL
int bitValue;
GetCtrlVal (panelHandle, inputControl, &bitValue);
strcpy(myString, "00000000");
// set one bit to 1
if (bitValue > 0)
myString[8 - bitValue] = '1';
SetCtrlVal (panelHandle, outputControl, myString);
return 0;
}
Message Edited by Al S on 08-18-2009 07:10 PM
