Which type of opto-sensors you should use completely depends on your application, and it is not possible to give you definite advice without knowing your application in detail.
Anyhow, since NI's boards have TTL level compatible inputs, you should use sensors with NPN output only. If the output of the sensor is activated (NPN transistor on), the input of the board will be tied to GND. If the output is not activated (NPN transistor off) the input will be tied to +5V by the internal pull-up resistors (it is not necessary to use the output pull-up resistor suggested by the opto-sensor manufacturer).
The decision to use light-on or light-off sensors rather depends on safety issues. You should make sure that the system is in a safe condition (for example, a condition which will not activate or which will stop a drive which might be harmful) even if a wire is broken or a plug is disconnected. Since the NI board have pull-up resistors, with the inputs open the TTL level will be high level. You should make sure that this is the output level of the opto sensor whent the drive in question is supposed to stop.
The digital inputs can be set to active high or active low by software. Of course the software settings have to match your hardware.