I've started a project which will be using an NI-9350, which is programmed with the new(ish) Function Safety Editor (May 2018). While the editor is functional (ahem), I keep getting snagged on its rough edges. Here's some feedback after poking around with it for a few hours.
- It's a new product. Please include help in the form of context help, tip strips (people have failed the CLD for less), and an OFFLINE manual.
- When starting the FSE, it's not clear there's a separate state diagram view. A big button labelled "Switch to Diagram" next to the Add Variable and Detailed Documentation buttons would be helpful (yes I know you can get there through the menu, or via those viewing switching options on the far right, but neither are immediately obvious)
- Speaking of the view switching options, changing the orientation and views repeatedly and in the "wrong" sequence can get into a state where I can no longer access the split view (even after resetting the workspace). Also the Full View option does nothing.
- If I'm in "split view" (even though the view isn't visibly split), pressing Ctrl+E to switch diagrams does nothing. I can see a blue splitter bar at the top of the screen toggle and that's all.
- State names. They can't have certain punctuation or begin with numbers. There are no errors or messages saying they have to conform to a naming convention. It is not documented in the manual they have to conform to a naming convention.
- Triple-clicking the state name on the diagram doesn't select all of the text, but does when triple-clicking the name in the pane.
- If the Errors + Warnings tab is closed and a Compile fails, it isn't automatically opened. There's just a message to say the compile failed and that's it.
- Entering the transition condition text is buggy. Text isn't updated correctly or just goes missing. It can get into a state where it is unclear what the actual condition logic is.
- Create a new transition, then click the grey priority label (not the wire). Enter the transition condition (say DI0) in the right-hand pane. Now click on a blank area of the diagram. The condition text is now gone (this much is a known issue, see CAR 726500).
- Repeat the above, but instead click on the wire (not the priority box). Now it works, and the condition is visible on the wire.
- Now click the wire and modify the condition to "DI0 || After 100 ms". Click on the diagram and the label updates. Now click on the priority box, and edit the condition to just DI0. Click on the diagram. The condition text on the wire has not updated. Click on the wire, and note the transition condition on the right reads DI0. The wire transition text and the pane transition text don't match up any more. It still compiles fine, but it's unclear what condition was using during compilation, which could have very real safety implications.

Like I said, this was only after a few hours of playing with the FSE. I understand it's still a new software product, but I'm surprised much of this wasn't caught or addressed before release.
Unless otherwise stated, all code snippets and examples provided
by me are "as is", and are free to use and modify without attribution.