12-19-2014 01:19 PM - edited 12-19-2014 01:20 PM
It seems he is wiring a boolean to a property node of a latch action switch (first guess, what else could it be?).
This will probably give an error at run time.
12-19-2014 01:34 PM
I'm fairly used to messy code. But the part that is annoying me more than anything is one of my main pet peeves: Value property node. Must...resist...killing...author...
12-20-2014 01:42 PM - edited 12-20-2014 01:43 PM
@crossrulz wrote:
I'm fairly used to messy code. But the part that is annoying me more than anything is one of my main pet peeves: Value property node. Must...resist...killing...author...
I opened a brandy-new application, yesterday, that we bought from an equipment manufacturer to control a process on my new line. That author had all of the controls & indicators outside the main While loop and wrote/read everything using Value property nodes - even ones that were only read/written in one place. The sad thing is that the JKI State Machine was used (at my predecessor's request) and there was the "Data Initialize" state with the cluster that was never referenced again...
01-02-2015 10:44 AM
@JÞB wrote:
(Hey thats a depreciated read from text- how old is this code?)
I had to LOL. The code isn't worth as much as it used to be? Well, at least it wasn't deprecated. I can appreciate that.
Rob
01-09-2015 07:55 AM - edited 01-09-2015 07:55 AM
There is soooooooo much wrong with that code, but I have to say that this bit is probably one of my favourite issues I see often:
Where is the wire?????? Oh, probably behind the case structure. How do I get to it to trace it back with a simple triple click then?? Erm....dang.
01-09-2015 08:51 AM
01-09-2015 09:29 AM
@jcarmody wrote:
I noticed this the other day. Wanna guess what's in the False case?
A TRUE constant? Which would mean it could just be replaced with a NOT.
A FALSE constant? Well, who knows what they are trying to do.
01-09-2015 10:03 AM
@jcarmody wrote:
I noticed this the other day. Wanna guess what's in the False case?
Don't you read my posts Jim?
01-09-2015 10:18 AM
@JÞB wrote:
@jcarmody wrote:
I noticed this the other day. Wanna guess what's in the False case?
Don't you read my posts Jim?
Well I still do.
Ben
01-09-2015 11:21 AM