Why some people say Local Variables are bad...

[Yamaeda]

As i understand this was once a C program, yes. The picture is from one sub-vi i have inherited, so it's not my code. I'm sure i do my fair share of GDC and other mistakes, but this one isn't mine. 😉

I've read your nugget on AE's and i've tried it in a connected project. There's been a few connected project where i've been able to start from scratch and done event driven constructions which i'm pretty happy with. There are a couple of ugly solutions here and there, but generally feels like it follows the guidelines from these forums.

/Y

[Ray.R]

Found here:  http://forums.ni.com/ni/board/message?board.id=170&view=by_date_ascending&message.id=481408#M481408

Not only was the code Rube Goldberg (convert to double would have done the trick), it also uses Local Variables instead of wiring directly.

The snippet messed up the diagram..  My guess is that snippets do not like Locals either..  😉

Wiring directly would have eliminated 2 indicators and 2 Locals  plus eliminated the need for a Flat Sequence Structure...  An added bonus would have been cleaner code.

 

Message Edited by Ray.R on 03-11-2010 08:03 AM

[Broken_Arrow]

---

Ray.R wrote:

The snippet messed up the diagram..  My guess is that snippets do not like Locals either..  😉

---

Snippets convert locals and static property nodes to strict nodes.

[Ray.R]

Makes sense.. 

I still like the idea that snippets don't like Locals..  LOL!!  😄

[Broken_Arrow]

---

Ray.R wrote:

Makes sense.. 

I still like the idea that snippets don't like Locals..  LOL!!  😄

---

Being from Florida, I like the Locals, but I appreciate the fact that Globals keep me from paying state income tax!

[altenbach]

---

Ray.R wrote: 

Wiring directly would have eliminated 2 indicators and 2 Locals  plus eliminated the need for a Flat Sequence Structure... 

---

You cannot wire directly, because the indicators are in opposite cases, so one remains stale with each call. Thus we need a feedback node as discussed in the original thread. (Or this idea ;))

[Ray.R]

I jumped too quickly on that  "Bandwagon" and ended up making a fool of myself for not reading the first post.  Maybe I should redeem myself by posting the actual solution..

[DianeS]

Ooo!  Ooo!  Ooo!

Here we not only wire to both the indicator AND a local variable of itself, we also have ANOTHER local variable sitting right inside the loop!

Spotted here.

[altenbach]

How helpful is this suggestion??? (compare with the actual question!)

Message Edited by altenbach on 03-19-2010 01:35 PM

[RayFarmer]

I am sure AndyC was just showing how to to use the property node