Sample CLD (Car Wash) Solution for Review

[Steve_Tomany]

Hi,

This is my first time posting. I am studying to take the CLD and I have attached my solution to the Car Wash sample exam (LV2011) using a PC-Events architecture. I ignored the time constraints for now to see where I stand as far as functionality and style. I tried to be thorough (not creative) with documentation as well. Any feedback would be greatly appreciated.

Thanks!

Steve T., Engineer

NSTec

[BrianInTheForest]

Took a quick look at it.   Not bad.

Things I think you could improve on.

1. Document all the constants
2. Try to fit the block diagram on one screen...I had to scroll
3. Goes along with item 2 try to make diagram a little more compact
4. Add Label on every wire

[JÞB]

Overall not bad clean readable code that does what it is supposed to do.

You have a BAD habit of saving everything on screen 2 (This is not technically a style ding but... it sure is annoying and do you really want to annoy the reviewer?)

Run it through the vi analizer- your BDs are too big (and some saved maximized)  This will cost a style point.

Wash stages.vi has some serios problems that will cost additional points:

• orphaned type def "Current Station" in case "Clear" causeing many coersions
• Terminals of controls wired to the connector pane are not on root diagram  (Search for the "Clear as Mud" Thread) to learn about the performance cost of this mistake.

Points I would point out that may save you down the road:

• Name your queues
• Create a sub-vi for your consumer (And let it obtain its own ref to the named queue)

This will help with code readability and BD sizing

Tip strips on everything the user can see!  and use them to explain the purpose of the object (What the user sees, what will happen if the user presses that)

this looks like a middle pass. missing points for style and documentation (Those tip strips really ARE the #1 communication from developer to user- important!) watch out for those BD sizes! and good luck

[Steve_Tomany]

Great, thanks for the feedback. Any chance you can show me how you use the queue naming and the sub vi in this way? I've played with it but my attempts do nothing to improve the BD.

Thanks

[JÞB]

---

@Steve Tomany wrote:

Great, thanks for the feedback. Any chance you can show me how you use the queue naming and the sub vi in this way? I've played with it but my attempts do nothing to improve the BD.

Thanks

---

Sure,  Here is a copy of my PC loop (events) template with the consumer loop as a sub-vi (Type Defs disconnected)

(NOTE: my template contains vi documentation template as well)  This won't save you on the CLD exam since the shipping templates are all you can use.  But having your own for "Real Life" sure speeds up programming time.

[johnTHomas]

please can you give me the solution he doesn't execute as normal