04-13-2017 11:35 AM
Hi @kosist90
Thanks a lot for your reviews. Its really helpful...
I couldn't get your 4th review point
"For subVIs - try to put controls on the top-level of the block diagram. So, controls will not be inside structures (like you have control "Accounts data" inside of the Case Structure in CLD_CSV_Write.vi)."
Instead of using 'Accounts data' cluster, should I need to use the complete cluster in the subvi?
04-13-2017 12:32 PM
Hello shree_bala,
Instead of using 'Accounts data' cluster, should I need to use the complete cluster in the subvi?
no, I mean the following (on example of another subVI):
This is how it is now (controls are not on top-level of block diagram, they are inside of case structure):
and this is the case, when controls/indicators are on the top-level of BD:
So, just take out your controls/indicators outside of the case structure, if it is possible, to the top-level.
Thank you,
Sincerely, kosist90
04-13-2017 01:10 PM
Main issue I see that hasn't been mentioned is that the program never terminates and it's impossible to do so (unless there is an error in the read or write file functions). The timeout case should stop the application instead of re-initializing, assuming the user has started a session by clicking the Card Simulator button.. The only way to terminate the application is through the abort execution button, which is a big no-no. Probably a simple mistake, but as a grader for an exam it would sure make me wonder... I would consider it similar to having a while loop that runs continuously at 100% CPU utilization... basically a non-starter.
I would change the name of the case that writes data to the file. Having a named 'Default' state is confusing given the typical usage of Default in a case structure. The confusion is compounded in this application since the Initialize state is also the standard usage of a Default case, so there are two 'Default' cases meaning different things. Since the named 'Default' always writes the file, something like 'Write File' would make more sense. Also, since you are using an enum for the case selector, a standard usage Default case isn't required if you have cases defined for all possible enum values.
@shree_bala wrote:
Hi,
Thanks a lot for the comments and review for car wash sample exam.
Today i did the ATM machine. But i took extra 45 minutes to finish it completely. I have attached my solution, please review it.
I also saved in LV 2014 version.
Question:
When i use a reference to update/enable the FP control, should i need to close it?
Thanks & Regards,
Shree
04-13-2017 01:20 PM
But in the description nowhere mentioned about stopping the program when timeout occurs. If i have a same scenario (No desc. about stop the program) in the actual exam, what should i supposed to do?
04-13-2017 01:25 PM
@shree_bala wrote:
But in the description nowhere mentioned about stopping the program when timeout occurs. If i have a same scenario (No desc. about stop the program) in the actual exam, what should i supposed to do?
That's my interpretation from page 4 of the exam doc:
Note: If, at anytime after the insertion of the ATM card, the ATM controller does not detect use of front panel controls for 10 seconds, the Card Simulator button should be released and the user session should be terminated by stopping the application. The ATM Messages indicator should display the Session Terminate Message.
04-13-2017 01:31 PM
Oh sorry. I didn't noticed that..
Thanks dhendrix11
04-17-2017 05:49 AM
Hi folks,
Today I did the sprinkler controller sample exam. Let me know your comments and reviews.
TIA
Shree
04-23-2017 06:03 AM - edited 04-23-2017 06:04 AM
Hello all,
I would be glad if someone could take a look at my Boiler controller solution and give me a feedback. I would like to know about my mistakes. It will help me to solve well in the actual exam.
Thanks & Regards,
Shree
04-23-2017 07:40 AM
Hello shree_bala,
I've checked this and previous one solution, and I can say that there is nothing to add to it. As for me, these examples are done in a way, that you can easily pass the exam.
Although, I didn't check functional part of it, e.g. coverage of requirement - this is something, that you can do by your own.
So, good luck on the exam!
Sincerely, kosist90
04-25-2017 04:19 PM
Hello All,
I have attached my sample exam for the ATM. Any feedback you all can provide is greatly appreciated.