Certification
Sample Exam Solutions for Review
Hello Hemant_LV,
let me give some short feedback regarding your code.
1. Icons for FGVs - as for me, it would be faster and more clear instead of text "FGV" + icon just write there text, as "Error handler FGV", etc.
2. Simulation flags - seems, that it's enough to have just one common Simulation? flag for all the modules.
3. API VIs for sending of commands by queue. In all VIs (at least, what I've checked), you have everywhere command "Exit". I understand, that this is kind of placeholder, but maybe, you'll get more points by specifying exact command/state name. It's couple seconds work, but then code would look for nicer. And specific inputs for queue data makes those VIs really API - becase you as an architect define, what data type would be sent. Now you let to send whatever data, what could cause issues.
4. Try to keep wires straight.
5. Queue FGV - better to set as Default state "Get", not Obtain.
6. In general, API VIs should define exactly implementation interface. I mean, that if you send command "Exit", no need to specify some data in queue payload. So, input "Message Data" is not neccessary.
7. Try to put more implementation details to the code. Of course, it's not possible to do it completely, but it seems as one module was created, and copied just N times. But then, it should be modified more specifically. For example, in GUI VIs you don't put to cluster data GUI controls references - but at the end, application would need it. And so on...
8. Top level.vi - better to name VI more exactly. Sensor.vi, User Console.vi, etc.
9. Error handler module could have at least functions for file open/write/close, etc. Also, maybe would be good to drop there (even let it be empty) vi for converting of Error Cluster to string message (which would be written to file).
10. " "", Default " state in state machine is not handled. Just drop there some 1 button dialog message - then it would be seen, that you handle unexpected state in debugging phase.
11. Put all modules to libraries, not just application. Error handler, Database - those guys also could have its own library.
So overall, as for me, it's good; but I'd advise you to focus more on functionallity interface implementation, and a bit of style (wires, aligning of functions on BD, etc.). For me, creation of module template + almost functional Error Handler module took approx. 1 hour. All the remaining time I've spent on API creation (with specific inputs/outputs), documentation, putting of requirements tags.
Wish you success with your CLA exam!
Sincerely, kosist90
Hi Mauricio
Couple of comments:
1 - You should set up your application with a project (.lvproj). Points will be deducted if you don't.
2 - Your functionality is not bad. However, I noticed that if I selected an option from zone 1 and zone 3 then
started the wash and moved out of position, once I moved back into position, your zone indicators no longer
matched your selections (e.g. If you select Tire Shine & Foam, you will see the Air Dry indicator illuminate when
the Tire Shine & Foam should be illuminated under the Out of Position event described above.)
3. You might want to incorporate a "Time elapsed" boolean in your FGV timer. It might make it easier to
put logic together to advance your state enumerator and reset things.
All in all not bad.
Mark Blair
Hello Hemant_LV,
as for me, project structure itself, and documenting (also requirements "tagging") are completely fine - everything is logically separated; in comments you give explanation about what and how should be implemented, what is nice. Maybe, just you could use more tags in comments...
Sincerely, kosist90
