I've written a script for a two channel resultant calculation. I've used the DataPortal Selection to prompt the user to select two channels, then it goes into the calculation. The script works fine, but I'd like to build in some error checking. Here's what I'd like to check for: 1) Did the user only make two selections? 2) Are both selections Channels? (And not Groups) 3) Do both selections have the same unit? 4) What is the group index of the selected channels? (I need this so I can insure the calculation is done on the proper channels.) Seems like the Portal.Selection properties aren't as accessible, or maybe I'm not able to get the right syntax. Below is the full script without any of the desired error checking. If I can get #1 and #4 then 2 & 3 will be easy, just can't figure out how to get those two. Dim ChnA, ChnB, Resultant, GroupNo Call MsgBoxDisp("Please select two channels in the Data Portal") '-- Set Channels ChnA = Portal.Structure.Selection(1).Name ChnB = Portal.Structure.Selection(2).Name '-- Calculate Resultant Call ChnMul("[1]/"&ChnA,"[1]/"&ChnA,"[1]/ChnAMultiplied") Call ChnMul("[1]/"&ChnB,"[1]/"&ChnB,"[1]/ChnBMultiplied") Call ChnAdd("[1]/ChnAMultiplied","[1]/ChnBMultiplied","[1]/Added") Call ChnCalculate("Ch(""[1]/Resultant"")=Sqr(Ch(""[1]/Added""))") '-- Cleanup Data.Root.ChannelGroups(1).Channels("Resultant").Properties("unit_string").Value = Data.Root.ChannelGroups(1).Channels(ChnA).Properties("unit_string").Value Data.Root.ChannelGroups(1).Channels("Resultant").Properties("description").Value = ChnA&" & "&ChnB&" Resultant" Data.Root.ChannelGroups(1).Channels("Resultant").Properties("Name").Value = ChnA&", "&ChnB&" Resultant" Call Data.Root.ChannelGroups(1).Channels.Remove("ChnAMultiplied") Call Data.Root.ChannelGroups(1).Channels.Remove("ChnBMultiplied") Call Data.Root.ChannelGroups(1).Channels.Remove("Added")

OK, in that case it seems to make sense to check also whether both channels are selected in the same group. Please try this. Option Explicit 'Erzwingt die explizite Deklaration aller Variablen in einem Script. dim oPortalSelection, oResultA, oResultB, oResultAdd, oCurrGroupChns dim oChnA, oChnB, oResultant Call MsgBoxDisp("Please select two channels in the Data Portal") set oPortalSelection = Portal.Structure.Selection if oPortalSelection.Count = 2 Then ' check whether channels are selected if oPortalSelection(1).IsKindOf(eDataChannel) and oPortalSelection(2).IsKindOf(eDataChannel) then ' check whether channels are numeric if (oPortalSelection(1).DataType = DataTypeChnFloat64) and (oPortalSelection(2).DataType = DataTypeChnFloat64) then ' check whether channels selected in the same group if oPortalSelection(1).ChannelGroup.Name = oPortalSelection(2).ChannelGroup.Name then ' set channel group als default call oPortalSelection(1).ChannelGroup.Activate '-- Set Channels set oChnA = oPortalSelection(1) set oChnB = oPortalSelection(2) '-- Extra Error Checking If oChnA.UnitSymbol = oChnB.UnitSymbol Then set oCurrGroupChns = Data.Root.ActiveChannelGroup.Channels '-- Calculate Resultant set oResultA = ChnMul(oChnA, oChnA, "/ChnAMultiplied") set oResultB = ChnMul(oChnB, oChnB, "/ChnBMultiplied") set oResultAdd = ChnAdd(oResultA(1), oResultB(1), "/Added") ' prepare formula set oResultant = oCurrGroupChns.Add("Resultent", DataTypeChnFloat64) Dim sFormula, aSymbol(2), aValues(2) sFormula = "Res = Sqr(A)" aSymbol(1) = "Res" aSymbol(2) = "A" set aValues(1) = oResultant set aValues(2) = oResultAdd Call Calculate (sFormula, aSymbol, aValues) '-- Cleanup oResultant.UnitSymbol = oChnA.UnitSymbol oResultant.Properties("description").Value = oChnA.Name &" - " & oChnB.Name & " Resultant" oResultant.Name = oChnA.Name &"_" & oChnB.Name & "_Resultant" call oCurrGroupChns.Remove(oResultA(1).Name) call oCurrGroupChns.Remove(oResultB(1).Name) call oCurrGroupChns.Remove(oResultAdd(1).Name) Else Call MsgBoxDisp("Channel units do not match") End If else Call MsgBoxDisp("Channels needs to be selected from the same channel group") end if Else Call MsgBoxDisp("Data type missmatch") End If Else Call MsgBoxDisp("Please only select channels") End If Else Call MsgBoxDisp("Please select two channels") End If Greetings Walter

DIAdem

Channel Selection in DataPortal

Solved!

Author

Thanks again for the help Walter, your last bit of code works perfectly. "call oPortalSelection(1).ChannelGroup.Activate" was the missing bit I was looking for.

Message 11 of 11

(261 Views)

DIAdem

Channel Selection in DataPortal

Re: Channel Selection in DataPortal