DQMH Consortium Toolkits Discussions

cancel
Showing results for 
Search instead for 
Did you mean: 

Upgrading old DQMH modules - close module not quite right?

Hi all,

 

I'm going through some old code for a LabVIEW version update. Some of the code was originally written with DQMH 3.1 and has possibly skipped some versions between then and now (I see some of the VIs have been modified by the validation tool at 5.0 and 6.0 though...)

 

Anyways, I had an issue with a cloneable module that passes all validation tests at 7.1.1 but that would hang if I had multiple clones running and tried to close them all at once and wait for modules to close. I scanned through the closedown code as compared to a clean new module and found the old module was still calling the "Destroy module semaphore reference" in the close module.vi, whereas the new module doesnt have that vi and instead uses a notifier in the "First & Last Instance?" case structure... which the old module didnt use in the close module case, but DID have in the library after the validation tool was run.

 

2 questions then (maybe 3). 

1. Can I just essentially copy-paste the code from the close module.vi in a newly created DQMH module into the old one and just manually go through an switch the vis to the correct library versions (i.e. to use the vis from the old module)?

2. If I do do 1, do I need to do anything in any other VI? 

3. Why didnt the validation tool do this for me?

4 (yeah, I know) - would it be useful to have some kind of automatic "repair" type function for the framework/module sync etc VIs within a DQMH module to just replace them with the equivalents from the latest version of DQMH?  Obviously with the caveat that if the end user has modified those core functions at all, then that customisation would be lost.

 

Thanks!

 

Paul

0 Kudos
Message 1 of 2
(78 Views)

Hi Thomas,

 

Thanks - that's kind of what I thought. Are you aware of any other vis relating to shutdown or sync that I should be double checking against a new module? 

 

Thanks

 

Paul

0 Kudos
Message 2 of 2
(51 Views)