Inherited code is like a pinata. You never know what you're going to get, and it's almost always something you want to throw out. In your case it's bad all around. Well, starting with an event structure is a good first step. Not sure how this program is supposed to work, but I'd suggest looking into using the Producer-Consumer architecture. The producer part can handle the events and pass off operations to perform (the "data") to the consumer via a queue.
There appear to be several "top-level" programs in the folder, even though the project only calls out XMC_demo4. Are the others ones old and/or defunct versions? If XMC_demo4 is the program that needs to be "fixed", there are a number of subVIs that aren't called by it.
What version of LabVIEW do you plan to use.
Other tips:
- Meaningful controls - The toggle switch for the COM port selection is meaningless. What value is up and what value is down? This should be replaced with a menu.
- Correct controls - The cluster selection on the left is apparently intended to be used to select what operation to perform. However, you can have more than one selected, and since the code only looks for the first true, only the first selected one gets run. If this should be limited to just one selection then a radio button group should be used instead.
- Labels vs captions - Instead of making labels a mile long (like the label on the one graph), keep the labels short and make the control's caption long and descriptive. For example, the control called "Start freq GHz" could be changed to have a label of "fStart". Simple, and still meaningful. The caption can say "Start Freq, GHz" and be made visible instead of the label.
- Centralized session opening/closing - There seems to be a lot of places where VISA sessions are open and closed, or serial configuration done repeatedly. For instance, in cast 7 there's an inner loop that calls a "Command 4 and com setup" that initializes the serial port and creates the string to send. Reinitializing the serial port in each iteration of the loop is a waste of time and resources.
Gotta go now. Need to sleep...
