ATM Mock Exam

[helssoa]

Hello all, I have my CLD exams very soon. I would appreciate it if someone can sort psuedo-mark my exam and give me any feedback. Thanks

[Dennis_Knutson]

duplicate

[SteveChandler]

You forgot to attach your code.

[helssoa]

Sorry i forgot to click on add attachment. See attached this is not a duplicate.

[helssoa]

Won't accept my attachment (Zip file). Anyone know why?

[SteveChandler]

---

@helssoa wrote:
Won't accept my attachment (Zip file). Anyone know why?

---

Testing. The attached zipfile contains an empty LabVIEW project.

Under attachments click the browse button

select zipfile, click ok

click Post

Using Firefox 4.01 on Windows 7

Edit: It worked for me

[helssoa]

This is my final attempt. I am following your instructions which are no different to what I was doing before but I am on a different computer.

Please review the attached code and provide comments.

Thanks.

[SteveChandler]

Summary (My opinion only and I do not know how points are determined)

Documentation 9 (didn't document format of CSV file)

Style 8 (lot's of overlapping things on the BD, backwards wires, property nodes and invoke nodes have unwired error in/out, conflict in project)

Functionality 3 (Could not verify functionality since Accounts info.txt is empty)

Total 20 (Fail)

Account info.txt is empty. That just kills you on functionality! You would have only needed 10 to pass my grading (Disclaimer: probably different from what NI would have given you)

Account Verified.vi should be in the subvis virtual folder.

Account info.txt should be in the project.

Wiring could be cleaner. There are some overlapping things on the BD and backwards wires. You will take a pretty good style hit for that. Hint: Resize the input nodes in the event case to one element and drag it to the top or bottom of the structure to make room.

Reinit To Default in the Initialize case has unwired error in/out. Same for other property nodes.

You should document the format of the CSV file (which column is what field). Since the file is empty I have to search for the requirements document and populate the file to check functionality. No time to do that right now.

I would have made account info a typedef cluster.

There is a conflict when I open the project

[helssoa]

Steve thanks for your reply. POINTS I DISAGREE WITH: 1) I dont have any conflicts when i open. 2) Account info is not empty it contains the following text: 12345,John,Doe,480 23456,Jennifer,Rodriguez,1000 34567,Bryan,Smith,750 45678,Julie,Ramirez,900 3) Very few wires are backward. There is a couple in the "Verify User Account" state. Some overlaps such as in the "Withdraw" state however sometimes this is unavoidable. I agree wiring could be cleaner but on the whole its o.k. and most importantly it is readable. I agree with everything else you have mentioned. QUESTIONS: 1) How do I document the CSV File? By adding a header to the file? 2) By "I would have made account info a typedef cluster." Do you mean you would convert the data read from txt file into a cluster?

[JohnCS]

Don't be so quick to disagree with SteveChandler's review of your sample project.  

Re comment 1: There is a conflict. The project files hierarchy refers to the control Menu.ctl  in two different locations. Looks like somewhere along the way, you used a copy of the control from: 

C:\ ATM Solution\Control\Menu.ctl 

but the project couldn't find a control at that location on either SteveChandler's or my machine. Instead it found a copy at:

C:\ .  . .  . .  .\ATM 4\CLD Example Exam - ATM Machine\Solution\Controls\Menu.ctl.

and generated the conflict. You won't get that conflict on your machine, but it will show up on any other computer on which  the project is loaded.  When you save a project, you should check the project's file hierarchy for components located in unexpected places. 

Re comment 2: The account data had the data you mentioned when the project is launched. However, the account data can be lost because you have a dreaded Fatal Error: If one presses enter without inserting card, the account data could be lost. (This would be the "Brat Who Hits All the Elevator Buttons"  use case.) Or if the log in is not completed before your event structure times out, the account data may be lost. (This is the "Little Old Lady Who Is Not Sure What To Do and Hesitates Since There Are No User Instructions" use case.)  In either case, you write the account file without having  fully authenticated the user. 

You should not write to the account data file when the log in fails. Any time you change your account data, you should keep a copy of the before transaction account data in case  the user needs a do-over.  Better yet, every transaction or attempted transaction should be recorded in another log file. 

I'm not sure if the suggestions I made are pertinent to the specifications of the test, but I think they reflect the good practices that a CLD should follow.

JohnCS