LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

CLD sprinkler Contoller

Hi ,

  I am taking CLD within a week, here is my solution for sprinkler controller.

Please review it and give me feedback. Thanks in advance.

Aarthi
0 Kudos
Message 1 of 5
(2,672 Views)

Hello Aarthi,

 

Implement Error Handling in your code.

Thanks and Regards
Himanshu Goyal | LabVIEW Engineer- Power System Automation
Values that steer us ahead: Passion | Innovation | Ambition | Diligence | Teamwork
It Only gets BETTER!!!
0 Kudos
Message 2 of 5
(2,658 Views)

Hi,

 

First impressions:

 

The Zone Service.VI:  Add labels to the cases stating what they are checking for, it is difficult to see at first view what they are toggling.

 

Zone Service VI has an indicator called Boiler States, hmmmm.......

 

In the Run State, label the case that checks the previous state.

 

FWIW Smiley Happy

-------
Mark Ramsdale
-------
0 Kudos
Message 3 of 5
(2,647 Views)

Hello Himanshu Goyal,

    Thanks for checking my code. Error handling like what i have to do? Clear error?

Or as pop-up message to user or writing a log file. I dont understand the way how to handle?

Can you please give me some example. Thanks.

Aarthi
0 Kudos
Message 4 of 5
(2,637 Views)

Hello Mark,

   First thanks for getting through my code.As you said i will label all case structures.

Other than that anything i have to improve? Thanks.

Aarthi
0 Kudos
Message 5 of 5
(2,635 Views)