Car Wash CLD Mock Exam

[helssoa]

I have my CLD exams soon. I would appreciate it if someone can sort psuedo-mark my exam and give me any feedback.

[Dennis_Knutson]

Stop posting the same request. Your request is meaningless without coe.

[SteveChandler]

I don't think they are the same request. He did three different sample exams. It is probably better to put them in different threads. He simply forgot to add the attachments.

[helssoa]

I have attached this time.

Thanks in advance.

[SteveChandler]

See my comments on your ATM solution for style

Two subvis are not documented

The main vi FP opens to full size and does not have an icon

No tip strips on Wash Display

Wash buttons are not initialized to default when the program starts. (Press some buttons, click abort then run. They stay pressed)

Summary (See my disclaimer in the ATM thread. I am not an NI grader and don't know how they do it so this is a guess)

Documentation 8

Style 10

Functionality 14

Score 32 (Pass)

[James_McN]

Hi Helssoa,

I don't have a complete mark scheme and so couldn't offer a full mark breakdown but I do have some suggestions:

1. Some of your labels on the front diagram aren't big enough for the text or are starting to overlap the item above.  This should not be the case.
2. You have used a design pattern which is good but you have basically created a state machine without the state machine items.
3. The big difference between this and the state machine is an enum to drive the case structure.  You should create this as a type def as well for easy updates.
4. Your style needs to be tidier.  The array w/ subset deleted indicator has the wire the wrong way and a lot of the wires have unecessary bends in them.  Try using VI Analyzer to pick these items up. It should pretty much pass on the default settings.
5. You shouldn't use a property node to set the value of a control.  Local variables are preferrable.
6. You shouldn't use 'use default value' on the output tunnel to car wash indicators either.

I think that is most of the main things.  If you have VI Analyzer then running that on the VI should give you some ideas as well.  Best of luck!

Regards,

[helssoa]

Thanks James. 1. I would appreciate a screen print of the front panel so i can identify any overlapping. I can't see any on my screen (see attachment if it works! my attachments dont seem to attach from my laptop!!). How can I avoid distortion due to different screen resolution? 2. 3. Good point an enum datatype would be better suited 4. Agree 5. This is something I learnt recently. Agree 6. Agree. Thanks.