Challenge: Optimize my Code!

[Grub]

Yesterday I spent quite a bit of time trying to build this vi.  Essentially, it takes an array of ten booleans and searches for which values are true.  It then takes the indexes of all the true elements and builds an array of those indexes.  Those indexes then are used to index an array that stores serial commands for an RS232 instrument.  Is there a simpler way to send a sequence of commands from a user interface that has individual buttons for each command?  The user needs to see all command buttons at once. make his/her choice(es), and execute the sequence.  I can see a way to do this with queues, but you still would have to 'translate' button pushes into indexes.  I hate doing more work than I have to, and I plan on implementing this user interface several times.  Any input to improve it would be appreciated.

Grub

[shoneill]

"Optimize my Code!"

"I hate doing more work than I have to"

Nah, pull the other one.

I can't open your VI as I've only got 6.1, but it sounds like it's something which souldn't be too hard to do.

Why don't you have the booleans in an array and use a for-loop to send the apprporiate commands.  Sounds to me like you've a level of processing too many.

Check out my example

Shane.

[Grub]

Ahhh, I forgot to mention that I'm doing this in RT...so no build arrays allowed.

Grub

[shoneill]

I'm not familiar with RT.  No arrays allowed at all or just no dynamic allocation of arrays....?

If the latter, instead of building an array, stick your instrument communication VI inside the case structure of the while loop and that should do it really.

Again, no RT experience..

Shane

[unclebump]

I like the boolean array to load steps into a queue. Then use the queue elements to determine the states to execute in a state machine architecture.

[Grub]

Nice Uncle Bump!

I like the way you used the booleans in the array to set the true or false case.  I had never thought of using it like that.  I think I'll use your solution in my upcoming modules.  Thanks....

Grub

[Grub]

Here is my original implementation...the subVI is the one I posted earlier....

Grub

[altenbach]

Why are you jumping through so many hoopsloops 😉 for this simple task? A much simpler version is show in the attached modification. There are many ways to do this.

Message Edited by altenbach on 08-30-2005 08:55 AM

[Grub]

Thank you altenbach,

I see that in your implementation you also used the booleans from the array to control the case structure.  I have never used the reshape array command, but can se how it would be useful (especially in this example).  Thank you for your input.

Grub

[altenbach]

Reshape arrray is one of the more useful, but often overlooked array tools. Even on simple 1D arrays, it can be used to either trim or pad (with zeroes) an existing array to a new lenght. One of the advantages is its efficiency because it does not move data in memory. It is thus very fast. 🙂

Check the online help for more details.