LabVIEW

cancel
Showing results for 
Search instead for 
Did you mean: 

Create list of combination

Hi abhinandan,

 

please change your subVI "Partial product" like this:

check.png

No need for local variabels - or even more worse "value" property nodes!

 

You need to learn about using AUTOINDEXING!

 

- Why do you use "Wait (ms)" instead of "Get Time"?

- Remove local variables, especially those used to update the indicator. They all take processing time…

Best regards,
GerdW


using LV2016/2019/2021 on Win10/11+cRIO, TestStand2016/2019
0 Kudos
Message 11 of 13
(708 Views)

I have made that change.

 

the code looks more professional now

 

thank you

Smiley Happy

 

 

But this does not seem to solve the problem of execution speed.

Did you get better results with the suggested changes ?

 

 

the main vi still takes more than a minute for a larger input array

 Smiley Sad

I am pretty sure that the sub vi was not the problem

Smiley Sad

 

 

0 Kudos
Message 12 of 13
(700 Views)

Hi,

 

I'm pretty sure the subVI was part of the problem: using "value" property nodes is way more slow than working directly with data using shift registers or autoindexing…

 

You need to cleanup your mainVI too: remove locals, use indexing, ...

Best regards,
GerdW


using LV2016/2019/2021 on Win10/11+cRIO, TestStand2016/2019
0 Kudos
Message 13 of 13
(692 Views)