Trigger crash when source added - LabView 2017

[Baptiste.Guilleux]

Hello,

I am updating a test bench made with LabView 2017 and I have to modify the attached VI.

This programm purpose is to generate and acquire the values of cDAQ NI modules.

If the marqued source is filled the programm crash, otherwise if not, the digital front is passed but the following start task won't have the required source.

When the programm crash I obtain this error :

Exception : Access violation (0xC0000005) à EIP=0x2089EB6B
Version : 17.0f2 (32-bit)

Hardware :

[paul_a_cardinale]

That's quite the monstrosity.

You're better off throwing it away and starting over.

[Baptiste.Guilleux]

Do you have some advices to start over ? 

[GerdW · Accepted solution]

Hi Baptiste,

---

@Baptiste.Guilleux wrote:

Do you have some advices to start over ? 

---

This is your current VI:

The white area in the navigation window marks one FullHD screen: your VI is way too large and not maintainable…

Advice:

• Use a project file to organize your project.
• Create subVIs, especially for recurring tasks/code snippets…
• Cleanup code: straight wires, left-to-right arrangement.
• Avoid coercion dots: they have a meaning!
• …

[Baptiste.Guilleux]

Thanks you GerW for this response.

This sub-VI is part of a much larger project with multiple sub-VIs. As mentioned, this is a project that we are taking over, making changes to the initial project. I send you the main file of the project. Do you think it's worth making changes to this, or would redoing everything be a more useful solution?

Have a nice day.

[GerdW]

Hi Baptiste,

---

@Baptiste.Guilleux wrote:

would redoing everything be a more useful solution?

---

Yes. Definitely:

Your main VI also is way too big, so the same advices apply…