can anyone fix this vi

[unknown19]

The right button is not working in this vi. Can anyone fix it??

[aeastet]

What version of LabView are you using? I would recomend that you use an event structure vs polling that you are currently doing.

[GerdW]

Hi unknown,

another one of that AUB bunch busy with a TicTacToe game? Do you know "michealjackson'smoonwalker" or "g12345678"?

Well, do you talk of the "down" button? What should it do? And how should it force any action when it isn't connected anywhere?

Why do you use all those locals and sequences when a wire would do it all?

Why don't you use a simple boolean array constant in the first sequence frame?

Message Edited by GerdW on 12-09-2009 02:38 PM

[unknown19]

I am using version 9. I just need someone to fix the right button or make me a simpler one.

[GerdW]

Hi unknown,

as you're using LV2009 why don't you use the cleanup tool from time to time? It has a reason to exist

"need someone to fix the right button"

This means "someone to do my homework"! This isn't compatible with agreed rules for this forum...

Are you talking about the button labeled "right" or the button to the right? It's quite a difference...

Message Edited by GerdW on 12-09-2009 02:44 PM

[unknown19]

What is AUB???

i am an amateur in labview programming and i am learning about it

[GerdW]

Hi unknown,

don't know AUB? Search for the users mentioned before that have shown exactly the same front panels (same labels, same buttons, same questions) to learn more about AUB

And yes: you're a beginner in LabView judging from your attached vi...

Message Edited by GerdW on 12-09-2009 02:47 PM

[johnsold]

aeastet,

You can tell in what version a VI you have downloaded was written by looking at VI properties  >> General: List unsaved changes.  unknown19 is using LV2009.

unknown19,

I see you have not rtried my suggestions in your other thread.  I do not have time now to fix it.

You should look at the style guides: Keep diagrams no larger than one screen.  Run wires from right to left.  Avoid local variables where a wire will do.

Lynn. 

[Norbert_B]

He is using LV 2009. If he wouldn't, opening the VI in newer versions would create the *-symbol in the end of the VIs name showing that there are unsaved changes. Looking into the VI settings >> General >> List unsaved Changes would reveal the original version.

To answer the question:

The VI has too many unnecessary local variables and lacks in a proper architecture. You do not have a timing in your loop leading to 100% CPU load at a single core. Please look into the State Machine (Video and Exercise here) or the UI Event Handler for further info (event handler only with LV FDS oder PDS).

Additionally, your algorithm for shifting the active LED is no good. I cannot give you any useful information on a solution since it is not clear how the move should look like (what happens if LED is shifted out of the 3x3 array in any direction? Does it appear on the opposite side in the same column/row or does it shift to another one?)

[unknown19]

i need the button labeled right to be fixed. it should light the boolean to the right of the lit boolean of the array.