getting rid of stack sequence

[krispiekream]

Are you still writing to the global somewhere?


at this point. that is the only time it is writing to the global.
it will probably write again somewhere is.
right now. it is just saving the measured temperature into the data file.




Message Edited by krispiekream on 07-08-2008 05:08 PM

[RavensFan]

Recommendation for your Meas_mod subVI.

In a couple of places you have your args value in several nested true/false case structures.   Basically a large If/Then/Else.  In the end, the only output are a pair of booleans.  I would recommend creating a single case structure that you wire  your arg value into.  It would have separate cases for none, stat, raw, both, and a default case equivalent to the false case of are=both.  Then you have one case structure and you populate each case with the constants that apply to the true case of each original case structure.

You might even be able to merge frames 0 and 1 of the flat sequence structure (it looks like there are no dependences) or at least convert them to a flat sequence for easier readability.

[krispiekream]

i dont know if i should work on all the subvi.
it will take me years.
what about just concerning with the main vi?
i am having a hard time with STAT_DATA_MEAS_PARAM
use MEAS_MOD and connect that out to STAT-DATA_MEAS_PARAM
can someone help me with that?

[RavensFan]

You have a couple of pieces of VI's that looked like they were connected at one time, but not anymore.

In UntitledMod (is that the main VI you are talking about?), the first sub VI is meas_mod.  It has a cluster coming out of the middle right side called stat_data_meas_param.  But your meas_mod VI does not have an indicator for that, let alone be connected to its connector pane.  So you need to add that indicator to the subVI and connect it to the connector pane.  (Also connect the Error In cluster).

In meas_mod VI, you have 2 different global variables stat_data_meas_param and stat_data_meas_param 2.  Where else are they used?  These are different from each other and neither has anything to do with the wire in the UntitledMod VI.

[krispiekream]

"You have a couple of pieces of VI's that looked like they were connected at one time, but not anymore.

In UntitledMod (is that the main VI you are talking about?), the first sub VI is meas_mod.  It has a cluster coming out of the middle right side called stat_data_meas_param.  But your meas_mod VI does not have an indicator for that, let alone be connected to its connector pane.  So you need to add that indicator to the subVI and connect it to the connector pane.  (Also connect the Error In cluster).

In meas_mod VI, you have 2 different global variables stat_data_meas_param and stat_data_meas_param 2.  Where else are they used?  These are different from each other and neither has anything to do with the wire in the UntitledMod VI."


i dont know how to make an indicator for the stat_data_meas_param since its a global item.
i copied and pasted but when the value changed, the one i copied and pasted didnt change. i also connect the wire to it too but it didnt change.
the code is not made by me, i am just working with it. the stat_data_meas_param is used throughout the code when it is displaying the temperture in the front panel. and the stat_data_meas_param2 is used every where else the stat_data_meas_param is used. let me attach some more images of where else these two global is used






-----------------------------------------------------------------------------------------------------------------------------------------------

Message Edited by krispiekream on 07-09-2008 12:23 PM

[RavensFan]

What you can do is right click on the wire going into or our out one of the global variables.  Select create constant.  Now you have a constant of the correct datatype.  Right click on that and select change to indicator.

Now you have an indicator of the correct datatype which you can wire up to or copy to another VI.  (You should be able to do a right click and Create constant directly from the wire, but if not, do it in two steps.)

So you can wire it up in the subVI and also connect one of the connectors in the connector pane to it so you can pass it out of the VI.

[krispiekream]

i think i did it right.
but the value is not the same
do you think you can create it from my untitlted.vi for me so i can see it?



Message Edited by krispiekream on 07-09-2008 01:30 PM

[RavensFan]

Here is a cleaned up version of UntitledMod where I created an indicator from the wire.  (And brought in the lost terminals tighter to the diagram and replaced some local variables with unused terminals.

As for the error message in the screen shot you posted.  You will have to debug that meas_mod subVI as that is the source of the error.

If you still have a problem.  Please post all of the latest copies of your VI's.  The VI's are scattered among numerous older messages, and they don't often match the screenshots you are posting.