Can you give me some suggestions for encryption decryption

[karthik9]

ok i've written my own encryption decryption techniqu can you suggest me some better methods

[Ranjeet_Singh]

Can you convert it to 2011.

[johnmountney]

What do you mean by better? ... More secure? Faster? Reliable? Practicality? Feasibility?

Have you published this wok in a journal or conference proceeding?

This paper is a few years old, but you could start here: http://ieeexplore.ieee.org/xpl/articleDetails.jsp?tp=&arnumber=1598556&queryText%3DA+Performance+Com...

[RTSLVU]

How about this?

I made it to work for text files, but it will work for binary files too with very little modifications.

Basic encryption is simple XOR a data stream and a repeating key, decrypt by XOR the encrypted data with the same key.

The longer the key the more secure the encryption.

[karthik9]

Not to publish ... this is very simple ... i just want to know should i improve this or scrap this

[RTSLVU]

You should not store the encryption key inside the encrypted file.

This makes your encryption weak in general.

You seem to have "security through obscurity" in your enc/dec algorithm.

[RTSLVU]

---

@karthik9 wrote:

Not to publish ... this is very simple ... i just want to know should i improve this or scrap this

---

You haven't replied but I guess I haven't answered your question either...

Sure it works but from a LV programming standpoint it is very redundant and Rube Goldberg like.

IMHO you should scrap what you have or at least clean it up.

I am a long ways from being a LV expert but there are the things that pop right out at me when I see your code.

You use identical code in three places, make it a sub-vi.

Why start with a constant of -1 and increment it once inside your for-loop? This value will always be 0. 

Don't use array size to set the number of iterations of your for-loop then use the iteration counter to index an array inside the loop, use auto indexing. 

Your block diagram is sloppy and hard to follow.

[altenbach]

The topic of this thread has been revisited And other alternatives posted.