LVOOP code review

[nathanscharfe]

Hello everyone,

[If I've posted in the wrong place, I apologize. Please let me know.]

This post is just to ask for opinions on the LVOOP code I wrote (attached) as a demonstration exercise. It's not for a test or anything, I am just trying to develop my LVOOP skills further, and this code will eventually be a part of a portfolio of my work. 

1. Do you think I am using LVOOP properly?

2. Can you find any bugs or anything I should do differently, clean up, or document better?

3. Do you have any suggestions as to how I could expand or make this demo program better?

Thanks!

[Charles_CLA]

Here's my $0.02:

1. Do you think I am using LVOOP properly?

Generally speaking yes, there is nothing wrong with what you have done.

2. Can you find any bugs or anything I should do differently, clean up, or document better?

I would either connect all of the error wires, or leave a comment explaining why error handling is not needed in that particular case.

3. Do you have any suggestions as to how I could expand or make this demo program better?

1. I would start with the template project Queued Message Handler, this will take care of problems like handling the user clicking on the X in the upper right of the window to close the program, only close the front panel if built as an exe, and a few other things. 
2. I would switch this to a plugin architecture, search a folder for class files (or packed project libraries) and dynamically populate the list of PCB's to be tested. This will allow for greater flexibility in the future as the code won't have to be rebuilt everytime there is a new PCB to test. 
3. I would have made the components data members of the base PCB object
4. I would have also made the testing of the components a method of the PCB object

[nathanscharfe]

Thanks Charles for your helpful insights! Kudos!