My first project; proposals for improvements?

[Dia791]

Hello guys!

My first VI is meanwhile complete (LV2019 32bit), and it does what it should do (at least the result is as expected).

It takes the signals from data cluster (filling of it isn't included here) and saves as TDMS file.

Additionally creates some statistic properties (e.g. current or voltage at the moment of min/max temperature difference).

The diagram is quite large; imo this makes it easiier to understand.

But: as "LV veterans" what would you say about the structure/view?

Would you combine anything, or change something in order to make the VI "better"?

Do you see any performance issues, for example due to the "unnecessary loops"?

All comments are welcome 😉

Greetings,

Vassili

[Vi.King]

Good Morning Dia791,

I have had a brief look at what you have created, the fact that it works is positive.

I have a few suggestions on how I would improve this program:

• Ensure that the code within each VI or Sub VI does not fill more than the screen you are working, all aspects should be visible at all times.
• Each different task, function or stage should be enclosed in its own Sub VI, this makes it so much easier to fault find, condense and make your code more efficient as well as making it easier to understand.
• Regarding the above, I enjoy using flow charts to plan in advance what I need to make happen and when, some free software I can recommend is UMLet.
• Once you have made Sub VI's it is a good idea to introduce an error cluster in order to force the sequencing of events, and to ensure the software deals with any errors in a safe and controlled manner.
• You may also find the use of clusters useful to condense the various data lines and wires you have going to multiple locations.
• I also always appreciate a clean looking User Interface.

Apply the above and you'll be flying! Good luck, and keep up the hard work 🙂