LabVIEW
Review
Solved!
- Do not name VIs with ".." before the file extension
- How are the VIs you have attached related to the problem?
- Your VIs containing missing subVIs.
Your VIs are "right" if they produce the desired result for any defined input. You can check that yourself. No need to ask here. Does you code give the expected result? If not, in what way is it wrong (all wrong, sometimes wrong, partially right, computer crashes, etc.)
Once you have a working version, we will be happy to help and show you how the same thing can be done with 10% of the code. 😄
You didn't include the "subset.vi", but I can tell you your "1.vi" will not work.
4bytes x U8 is 32bits. You are converting the 32 bits of information BEFORE you wire it to the "subset.vi". You are always sending the same bottom 8 bits.
Not sure if its the best way, but this is one way to do it. I converted the 4 bytes into a U32 integer. Then mask the bits that are needed, then shift them out of the U32 to get the next set of bits ready for the next iteration.
Instead of all that duplicate code, here's how I would parse the Date Code (note that the MSB is not used, so we can do all in I32. Makes the later +/- adjustments easier). I also would do a cluster output: self documenting, a single output connector, etc. You can always unbundle whatever you need later. (If you think you need more connectors than the default connector pane, something is wrong It also makes no sense to create output arrays (instead of scalars) for each field!!)
(Disclaimer: Not fully tested. Please verify correct operation. There might be bugs)
@altenbach wrote:
(Disclaimer: Not fully tested. Please verify correct operation. There might be bugs)
ali996
One minor bug I see is seconds is 2 x sssss
