LabVIEW
saved data in string on front panel
Solved!
Hi Tim,
@tominsek wrote:
I tried this method as Yamadea mentioed, only for COM port first to see if it works but it doesn't. If i close the app and i reopen it, i have to select the com port again, it doesnt save it in the ini file.
Where did you implement the INI file functions?
I don't see them in the code…
Hi Tim,
you did not follow the suggestions given by Yamaeda!
That's your code (after using CodeCleanup):
You implemented:
- writing to a key named by the content of the VISA resource
- setting NO VALUE to this key as there is no wire to the value input of the WriteKey function!!!
- reading the same key name (as given by the VISA resource) as string - even though you wrote it milliseconds before as a boolean key…
- NOT using the read value of the ReadKey function: why do you use a ReadKey function when you don't use the output???
Other questions:
- Why do you use a "value" property node AND a local variable of the same control? They both give the same value, but the first one is even slower than the second one!
- What's the point in writing the value to the file and reading it back immediately???
- Do you even understand (or atleast try to) what we try to explain? Yamaeda gave an example of both steps, reading and writing. And he wrote when to use the write and when to use the read part…
Hi Tim,
@tominsek wrote:
i Don't know what i'm doing wrong.
You don't seem to debug your own code.
Ever worked with breakpoints and highlight execution?
(This is basic LabVIEW stuff, explained in Core1 training courses. I expect you already knew that! And I expect you to actually take all those Training resources offered at the top of the LabVIEW board!)
Debugging:
- Is the code executed at all?
- Which data is written?
- Is there any error after CloseIniFile?
Why do you need one more local variable? Using them extensively is (most often) WRONG!
See this:
You already have the data in the shift register, so use that data instead of reading a local!
(You even put a typo in the string constant…)
Why don't you cleanup your code?
Why don't you use subVIs as one step to improve code readability?
Do you use a LabVIEW project file yet?
Hi Tim,
@tominsek wrote:
but i dont understand in wich state in my code i should put write key to file and in wich state i should put read key from file, because i need to save to file not only visa com port but also password for tab (nastavitve), parameters of sql data base( uid, pid ect...) and i have all these parameters scattered throughout the code in different cases.
That's why I (probably) mentioned before to use a better program architecture and get rid of all those local variables!
- Use one state to handle ALL UI actions by the user: each value change event of each control.
- Put ALL relevant parameters into the cluster in your shift register. (You may even use clusters inside this clusters to organize those parameters by purpose.)
NOW you can:
- add one more state (labelled like "read parameters from file") that reads all relevant parameters from INI file and puts them into the cluster, execute this state as the first state after program start
- add one state to update frontpanel from the data in the shift register
- add one state to write all the parameters from shift register into INI file, execute this state as last state before EXIT (or inside the EXIT state)
All this becomes very easy once you have a clear program architecture with a well-defined state machine, cleaned up code, more subVIs ("one VI per function, one function per VI"), and using all the suggestions I already gave…
