How to eliminate some local variables

[DickHutchings]

Each supply has 2 elements, a before and after. So there are anywhere from 2 to 8 measurements depending the number of supplies.

[aputman]

---

@altenbach wrote: 

Since the array elements for one supply are not adjacent, would you get one array with three elements if there is only one supply, discarding the second element? I asked for example arrays for 1,2,3, 4 supplies. Please give examples.

---

I'm confused because the original code showed the elements for each supply being adjacent and now the elements are not adjacent.  I think some time needs to be spent deciding what are the requirements, before any code is written, so that people trying to help you out aren't wasting their time.

[Ben]

While the suggestions on how to handle the data in the array are valid I want to back up and address the topic of this thread... eliminating Locals.

What I have seen in the code screams "Action Engine" because there is data that needs to be touched from different parts of the code and the result available in multiple places.

For each of the operation related to the data set that need to be performed implement an Action associated with type interaction with data. Init, Update, Evaluate, Get Updated ...

The suggestion that have been provided before this post give you option on "How to do" what needs to be done to the data, the Action of an Action Engine tell you "where to do it".

Ben

[DickHutchings]

[altenbach]

You attached an empty VI. Can you attach the code shown in the picture instead?

[DickHutchings]

This should be the one.

[altenbach]

Try this. You get an array of supplies.

Some of your subtraction are reversed, so I am not sure what's the right way, so swap the input to the subtraction as needed.

[DickHutchings]

If you look closely at the wiring, you'll se that the second wire of the first subtract vi moves down once per supply added and the first of each supply is perfectly sequential.

The code I show works and I could just put into a case selector and be done. I am looking to improve my code so I ask, is there a better way?

[altenbach]

Yes, my code considers that. Works just fine (except for 4 supplies, the sign is reversed. Not sure if this is significant.)

Using a cluster array to iterate over all, because the sizes vary. You only need the inner code, of course.

(NOTE: be careful and always show the first invalid element when sizing array containers (or show the scrollbar). Your first array actually had 4 elements. container size != array size!)

[altenbach]

Actual code (LV2017)